Added a more descriptive error message in the app boostrap.#450
Merged
atanasovg merged 2 commits intoNativeScript:masterfrom Jun 7, 2016
Merged
Added a more descriptive error message in the app boostrap.#450atanasovg merged 2 commits intoNativeScript:masterfrom
atanasovg merged 2 commits intoNativeScript:masterfrom
Conversation
|
💚 |
Contributor
|
👍 ping @Plamen5kov |
Contributor
|
@skarlatov, tested the PR, and you have my 👍 after small format fix I commented on. |
| if (!bootstrapFile.exists()) | ||
| { | ||
| bootstrapFile = resolvePathHelper("./bootstrap", ""); | ||
| String notFoundMessage = "Application entry point file not found. Please specify the file in package.json otherwise make sure the file index.js or bootstrap.js exists. \\n If using typescript make sure your entry point file is transpiled to javascript."; |
Contributor
There was a problem hiding this comment.
change "\n If using...", to "\nIf using..."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change the exception that was displayed by the run-time was too specific, lacking any meaningful information to the developer. If there was problem with the app main file the exception was:
"Failed to find module: ./, relative to: /".
Now the error message is:
"Application entry point file not found. Please specify the file in package.json otherwise make sure the file index.js or bootstrap.js exists. If using typescript make sure your entry point file is transpiled to javascript."