Workaround for V8 profiler in order to show correct function names in…#470
Merged
Workaround for V8 profiler in order to show correct function names in…#470
Conversation
… CPU profiles. By default, V8 maps all native functions to the address of the C++ handler (MetadataNode::MethodCallback). As a result there is only one entry (the last one) in the map for all Java methods. While using libffi to generate unique native handler with sole purpose to forward the call to MetadataNode::MethodCallback works fine on Windows, it does not work for Android x86/arm because V8 profiler cannot unwind properly the stack. Hence, we wrap all Java methods with JS functions and take advantage of ScriptOrigin.
|
💔 |
Author
|
ping @NativeScript/android-runtime |
Contributor
|
run ci |
Contributor
|
looks good |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… CPU
profiles. By default, V8 maps all native functions to the address of the
C++ handler (MetadataNode::MethodCallback). As a result there is only one
entry (the last one) in the map for all Java methods. While using libffi
to generate unique native handler with sole purpose to forward the call to
MetadataNode::MethodCallback works fine on Windows, it does not work for
Android x86/arm because V8 profiler cannot unwind properly the stack.
Hence, we wrap all Java methods with JS functions and take advantage of
ScriptOrigin.