Cache modules by unique combination of module path and basedir. This …

[slavchev]

…works well for global modules and helps with common requires. Essentially, the currently used map now contains more than one key (path) for a given module

[ns-bot]

💔

[atanasovg]

I am curious what's the performance gain from this refactoring? Also, is there a way we do all the path calculations on the C++ side and skip the Java marshaling at all?

[slavchev]

@atanasovg It is up to the application. For the app I am testing with it is ~90ms. It might not help for other apps. The scenarios where this PR helps are:

• frequently loading global modules (e.g. require("application"))
• frequently loading relative modules from the same base directory

It won't help much if you load sequentially require("./a/b/c") from basedir and require("./b/c") from basedir/a for example.

[blagoev]

look good

[Plamen5kov]

👍

[blagoev]

run ci

[ns-bot]

💔