Change Java inner classes convention#520
Merged
Conversation
petekanev
changed the title
Contributor
Author
|
Note: PR created to test CI, I'd need to add a couple more tests before its finalized. I'd also like to include proper logging/errors if and when the user doesn't instantiate inner classes properly, because right now the application crashes abruptly as a result of a jni error. |
|
💚 |
1 similar comment
|
💚 |
|
💔 |
4 similar comments
|
💔 |
|
💔 |
|
💔 |
|
💔 |
|
💚 |
1 similar comment
|
💚 |
|
💔 |
vchimev
force-pushed
the
pete/fix-inner-classes
branch
from
b47b470 to
ada2d73
Compare
|
💔 |
Contributor
Author
|
run ci |
|
💔 |
Contributor
Author
|
run ci |
|
💚 |
vchimev
force-pushed
the
pete/fix-inner-classes
branch
from
ada2d73 to
1996e68
Compare
|
💚 |
Contributor
Author
|
ping @NativeScript/android-runtime please review |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The changes in this PR are motivated by issue #366. They aim to provide direct access to constant fields in inner Java types, while the syntax to create instances of inner types will be kept as close to Java conventions as possible.
The changes to the syntax can be previewed here.
Does your commit message include the wording below to reference a specific issue in this repo?
Fixes #366 - Proposal 2 / Option 3
Does your pull request have [unit tests]
Previous unit tests testing inner class behavior have been fixed to comply to the changes made in this PR. More tests will be added in the following days.