Patch ast parser to respect TS 2.1.+ ES5 classes#653
Merged
Conversation
petekanev
force-pushed
the
pete/patch-ast-parser-ts2.1.4
branch
from
86a9f0c to
ddd2a87
Compare
|
💚 |
1 similar comment
|
💚 |
…ors emitted from the latest TS update
petekanev
force-pushed
the
pete/patch-ast-parser-ts2.1.4
branch
from
ddd2a87 to
40dd832
Compare
|
💚 |
slavchev
approved these changes
Dec 13, 2016
|
@Pip3r4o |
Contributor
Author
|
@roblav96 unlikely, because of holidays |
|
@roblav96 If it is critical I would suggest to use |
|
That's what I'm doing for the time being 😉 It's not a huge biggie though. Thanks mate! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #651
Changes:
https://github.com/NativeScript/android-runtime/pull/653/files#diff-5bd535083d3f5ff391a0e2f499ec352aR189
https://github.com/NativeScript/android-runtime/pull/653/files#diff-5bd535083d3f5ff391a0e2f499ec352aR127
Test included (execute manually -
npm install && npm run test)