Conversation
|
💚 |
Contributor
|
https://nodejs.org/api/modules.html#modules_all_together |
petekanev
force-pushed
the
pete/require-module-with-js-in-name
branch
from
b2bf115 to
1816ea6
Compare
|
💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved around logic for resolving modules when requiring to first check if the resolved file is an actual file, or we are trying to load a directory.
This is necessary when dealing with folders that may contain character sequences that look like file extensions, (
hash.jsis a module, not a standalone script) while not breaking https://github.com/NativeScript/common-runtime-tests-app/blob/master/Require/index.js#L204 as resolution for directories will succeed only if they contain apackage.jsonor anindex.jsTests added at NativeScript/common-runtime-tests-app#21
Addresses #666