gradle will respect productionDependencies.json file#708
Closed
Plamen5kov wants to merge 1 commit intomasterfrom
Closed
gradle will respect productionDependencies.json file#708Plamen5kov wants to merge 1 commit intomasterfrom
Plamen5kov wants to merge 1 commit intomasterfrom
Conversation
this file will contain all the production dependencies that are provided by cli if no such file is provided, we'll fallback to the previous behavior of traversing all of the node_modules and searching for all aar files
|
💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
3.0 cli, installs platform frameworks as dev-dependencies, so gradle shouldn't traverse them.
Solution:
CLI can pass the production dependencies as a json file, that gradle respects, and doesn't traverse unnecessary node_modules packages, searching for
.aarfiles. This template update, does exactly that.related CLI PR: NativeScript/nativescript-cli#2532