update js parser with corner case #863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 |
Contributor
|
@Plamen5kov could you add a data-row test case in the bindings generator tests to verify that a class extended in a file with name containing dots can be compiled in Java? |
Plamen5kov
force-pushed
the
plamen5kov/update_js_parser
branch
from
2d8e809 to
41d7fde
Compare
|
💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update js_parser to cover naming with a dot
While we are statically analyzing the application javascript code, we use the file_name as part of the name for the class, but if the file name contains a dot ".", the java class name becomes invalid. Replacing dot and other characters with a "_".
Fixes issue: #761