-
-
Notifications
You must be signed in to change notification settings - Fork 142
Update ASBG parser and ASBG generated classes tests to run on travis CI #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| (function () { | ||
| let { spawnSync, execSync } = require('child_process'); | ||
|
|
||
| console.log("Installing JavaScript parser test dependencies."); | ||
|
|
||
| let npmInstallResult = execSync('npm install'); | ||
|
|
||
| console.log(npmInstallResult.toString()); | ||
|
|
||
| console.log("Executing JavaScript parser tests using Jasmine."); | ||
|
|
||
| const subprocess = spawnSync('node', ['./node_modules/jasmine/bin/jasmine.js', 'JASMINE_CONFIG_PATH=jasmine.json'], { cwd: __dirname }); | ||
|
|
||
| let stdout = subprocess.stdout.toString(); | ||
| let stderr = subprocess.stderr.toString(); | ||
| let code = subprocess.status; | ||
| let err = subprocess.error; | ||
|
|
||
| if (code !== 0) { | ||
| console.log("Tests runner exited with a non-zero code."); | ||
|
|
||
| let errorString = stdout; | ||
|
|
||
| if (err) { | ||
| errorString = err; | ||
| } | ||
|
|
||
| if (stderr) { | ||
| errorString = stderr; | ||
| } | ||
|
|
||
| throw new Error(errorString); | ||
| } | ||
|
|
||
| console.log(stdout); | ||
| }()); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't override error string, but rather throw an object with both the
supbrpocess.errorandsubprocess.stderrso we don't loose informationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that both are set at the same time though? My understanding is that
subprocess.erroris raised when something goes wrong while spawning the process, whereasstderris a result of an error thrown inside the process.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I'm not sure if both can be present. It's just a suggestion when I look at the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throwing an object results in
[object Object]in the logs, which is not very helpful.