Some fixes to the Angular Tutorial#102
Merged
NathanWalker merged 4 commits intoNativeScript:developfrom Sep 24, 2022
DmitrySharabin:tutorial-angular
Merged
Some fixes to the Angular Tutorial#102NathanWalker merged 4 commits intoNativeScript:developfrom DmitrySharabin:tutorial-angular
NathanWalker merged 4 commits intoNativeScript:developfrom
DmitrySharabin:tutorial-angular
Conversation
According to the folder structure stated in the Folder structure section, the assets folder is in the app folder, not in the src one.
Since the app template provides app.css but not app.scss, we need to provide the styles in the correct format.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
Contributor
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
NathanWalker
approved these changes
Sep 24, 2022
Contributor
|
Thank you @DmitrySharabin ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, 👋🏻
Thank you so much for the awesome work you do by developing NativeScript.
I worked through the tutorial and found a couple of issues. It would be nice if we could fix them. 😊
Thank you!