Skip to content

Added API description for the Payments: IAP & Subscriptions plugin#84

Closed
Ombuweb wants to merge 1 commit intoNativeScript:developfrom
Ombuweb:develop
Closed

Added API description for the Payments: IAP & Subscriptions plugin#84
Ombuweb wants to merge 1 commit intoNativeScript:developfrom
Ombuweb:develop

Conversation

@Ombuweb
Copy link

@Ombuweb Ombuweb commented Jun 13, 2022

Added the API section describing all the methods offered by the plugin.

@cla-bot
Copy link

cla-bot bot commented Jun 13, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @Nandee89.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@rigor789
Copy link
Member

Hi @Ombuweb thanks for the PR, could you open the PR against this file: https://github.com/NativeScript/payments/blob/main/packages/payments/README.md as the contents in this repo are updated daily from the plugin readmes (so your changes here would disappear in ~24hours).

Sorry for the confusion - we plan to make this better when we get the chance...

@Ombuweb
Copy link
Author

Ombuweb commented Jun 14, 2022

Hi @rigor789, no problem. I will open it against the other file.

@Ombuweb
Copy link
Author

Ombuweb commented Jun 14, 2022

One question @rigor789, does that mean I should use the packages' README.md when contributing to packages docs and docs-new for other contributions?

@rigor789
Copy link
Member

Yep, plugins are separate and just pulled in daily on CI

The rest is managed here

@rigor789 rigor789 closed this Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants