fix console.log tests conforming to the new format#9
Merged
SvetoslavTsenov merged 3 commits intomasterfrom Feb 4, 2018
Merged
Conversation
This was referenced Jan 26, 2018
petekanev
force-pushed
the
pete/fix-console-tests
branch
from
9dd8e5d to
c0f2cca
Compare
SvetoslavTsenov
force-pushed
the
pete/fix-console-tests
branch
2 times, most recently
from
7ba1207 to
a21b4ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With console functionality being refactored for Android, some of the logs will print in a different format. The new implementation also allows some cases which were previously not valid. - Android changes - NativeScript/android#894
Modules tests - NativeScript/NativeScript#5190