Skip to content

fix(marshalling): Expose C strings as references to uint8 in JS#1208

Merged
mbektchiev merged 1 commit intomasterfrom
bektchiev/cstring-as-ref-to-uint8
Sep 17, 2019
Merged

fix(marshalling): Expose C strings as references to uint8 in JS#1208
mbektchiev merged 1 commit intomasterfrom
bektchiev/cstring-as-ref-to-uint8

Conversation

@mbektchiev
Copy link
Copy Markdown
Contributor

  • [Marshalling] Change underlying type of returned references from int8 to uint8
  • [TestFixtures] Use stringWithUTF8String instead of formatting with
    %s (which uses system default encoding)
  • [TestRunner] Add utf8 node module to TestRunner project
  • [TestRunner] Add a test with cyrillic characters which validates
    that references are indeed unsigned

PR Checklist

refs #1196

* [Marshalling] Change underlying type of returned references from `int8` to `uint8`
* [TestFixtures] Use `stringWithUTF8String` instead of formatting with
`%s` (which uses system default encoding)
* [TestRunner] Add `utf8` node module to TestRunner project
* [TestRunner] Add a test with cyrillic characters which validates
that references are indeed unsigned
@mbektchiev mbektchiev added the bug label Sep 17, 2019
@mbektchiev mbektchiev added this to the 6.2.0 milestone Sep 17, 2019
@mbektchiev mbektchiev self-assigned this Sep 17, 2019
@cla-bot cla-bot Bot added the cla: yes label Sep 17, 2019
@mbektchiev mbektchiev merged commit 775598a into master Sep 17, 2019
@mbektchiev mbektchiev deleted the bektchiev/cstring-as-ref-to-uint8 branch September 17, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants