fix(marshalling): Expose C strings as references to uint8 in JS#1208
Merged
mbektchiev merged 1 commit intomasterfrom Sep 17, 2019
Merged
fix(marshalling): Expose C strings as references to uint8 in JS#1208mbektchiev merged 1 commit intomasterfrom
mbektchiev merged 1 commit intomasterfrom
Conversation
* [Marshalling] Change underlying type of returned references from `int8` to `uint8` * [TestFixtures] Use `stringWithUTF8String` instead of formatting with `%s` (which uses system default encoding) * [TestRunner] Add `utf8` node module to TestRunner project * [TestRunner] Add a test with cyrillic characters which validates that references are indeed unsigned
vmutafov
approved these changes
Sep 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
int8touint8stringWithUTF8Stringinstead of formatting with%s(which uses system default encoding)utf8node module to TestRunner projectthat references are indeed unsigned
PR Checklist
refs #1196