Skip to content

docs: Clarify timer cleanup comment in removeTask #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 1 commit into from
Dec 3, 2025
Merged

docs: Clarify timer cleanup comment in removeTask #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions NativeScript/runtime/Timers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,8 @@ class TimerState {
it->second->Unschedule();
timerMap_.erase(it);
CFRunLoopTimerInvalidate(timer);
// timer and context will be released by the retain function
// CFRunLoopTimerContext context;
// CFRunLoopTimerGetContext(timer, &context);
// delete static_cast<std::shared_ptr<TimerTask>*>(context.info);
// CFRelease(timer);
// CFRunLoopTimerInvalidate triggers our TimerRelease callback, which
// deletes TimerContext, whose destructor calls CFRelease(task->timer)
}
}

Expand Down
Loading