test: exit TestRunner upon a crash instead of waiting for a timeout#373
Merged
edusperoni merged 1 commit intoMay 15, 2026
Merged
Conversation
testRuntime() previously called wait(for:timeout:) with a single 300s budget. If the runtime crashed (EXC_BAD_ACCESS or similar) the HTTP POST that fulfills runtimeUnitTestsExpectation never arrived, so the test would sit out the full 5 minutes before reporting a generic timeout — masking crashes as slow tests in CI. Add a 0.5s polling Timer that watches XCUIApplication.state and fulfills the expectation when the app reaches .notRunning, recording the exit via a didCrash flag. The Timer is registered on RunLoop.main in .common modes so it keeps firing while XCTWaiter spins the run loop. After the wait resolves, didCrash drives a specific XCTFail pointing reviewers at ~/Library/Logs/DiagnosticReports/TestRunner-*.ips, while a true timeout still surfaces as the original "exceeded N seconds" failure. Switching the expectation from self.expectation(...) to a standalone XCTestExpectation is required because XCTestCase tracks the former and requires waitForExpectations; driving it through XCTWaiter directly avoids that constraint.
edusperoni
changed the title
edusperoni
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testRuntime() previously called wait(for:timeout:) with a single 300s
budget. If the runtime crashed (EXC_BAD_ACCESS or similar) the HTTP
POST that fulfills runtimeUnitTestsExpectation never arrived, so the
test would sit out the full 5 minutes before reporting a generic
timeout, masking crashes as slow tests in CI.
Add a 0.5s polling Timer that watches XCUIApplication.state and
fulfills the expectation when the app reaches .notRunning, recording
the exit via a didCrash flag. The Timer is registered on
RunLoop.main in .common modes so it keeps firing while XCTWaiter
spins the run loop. After the wait resolves, didCrash drives a
specific XCTFail pointing reviewers at
~/Library/Logs/DiagnosticReports/TestRunner-*.ips, while a true
timeout still surfaces as the original "exceeded N seconds" failure.
Switching the expectation from self.expectation(...) to a standalone
XCTestExpectation is required because XCTestCase tracks the former
and requires waitForExpectations; driving it through XCTWaiter
directly avoids that constraint.