feat: enable nesting named page router outlets (#1556)

Author: ADjenkov

e2e/modal-navigation-ng/app/modal-second/modal-second.component.html

@@ -4,6 +4,6 @@
 </ActionBar>
 
 <GridLayout #rootLayout rows="auto, auto" (loaded)="onLoaded($event)">
-    <Button text="Go Back" (tap)="goBack()"></Button>
+    <Button text="Go Back(activatedRoute)" (tap)="goBack()"></Button>
     <Button row="1" text="Close Modal" (tap)="close(rootLayout)"></Button>
 </GridLayout>

e2e/modal-navigation-ng/app/modal-second/modal-second.component.ts

@@ -1,5 +1,6 @@
 import { Component } from "@angular/core";
-import { View, EventData } from "tns-core-modules/ui/core/view"
+import { View } from "tns-core-modules/ui/core/view"
+import { ActivatedRoute } from "@angular/router";
 import { RouterExtensions } from "nativescript-angular/router";
 
 @Component({
@@ -8,14 +9,14 @@ import { RouterExtensions } from "nativescript-angular/router";
     templateUrl: "./modal-second.component.html"
 })
 export class ModalSecondComponent {
-    constructor(private routerExtension: RouterExtensions) { }
+    constructor(private routerExtension: RouterExtensions, private activeRoute: ActivatedRoute) { }
 
-    onLoaded(args: EventData) {
+    onLoaded() {
         console.log("modal-second loaded");
     }
 
     goBack() {
-        this.routerExtension.back();
+        this.routerExtension.back({ relativeTo: this.activeRoute });
     }
 
     close(layoutRoot: View) {

e2e/modal-navigation-ng/e2e/modal-frame.e2e-spec.ts

@@ -33,8 +33,7 @@ describe("modal-frame:", () => {
 
             afterEach(async function () {
                 if (this.currentTest.state === "failed") {
-                    await driver.logPageSource(this.currentTest.title);
-                    await driver.logScreenshot(this.currentTest.title);
+                    await driver.logTestArtifacts(this.currentTest.title);
                     await driver.resetApp();
                     await screen[root]();
                 }

e2e/modal-navigation-ng/e2e/modal-layout.e2e-spec.ts

@@ -33,8 +33,7 @@ describe("modal-layout:", () => {
 
             afterEach(async function () {
                 if (this.currentTest.state === "failed") {
-                    await driver.logPageSource(this.currentTest.title);
-                    await driver.logScreenshot(this.currentTest.title);
+                    await driver.logTestArtifacts(this.currentTest.title);
                     await driver.resetApp();
                     await screen[root]();
                 }

e2e/modal-navigation-ng/e2e/modal.shared.e2e-spec.ts

@@ -18,8 +18,7 @@ describe("Shared modal from home and back", () => {
 
     afterEach(async function () {
         if (this.currentTest.state === "failed") {
-            await driver.logPageSource(this.currentTest.title);
-            await driver.logScreenshot(this.currentTest.title);
+            await driver.logTestArtifacts(this.currentTest.title);
         }
     });
 

e2e/modal-navigation-ng/e2e/screen.ts

@@ -27,7 +27,7 @@ const confirmDialog = "Yes";
 const confirmDialogMessage = "Message";
 const closeModalNested = "Close Modal Nested";
 const closeModal = "Close Modal";
-const goBack = "Go Back";
+const goBack = "Go Back(activatedRoute)";
 
 export class Screen {
 

e2e/modal-navigation-ng/package.json

@@ -57,7 +57,8 @@
     "webpack": "~4.6.0",
     "webpack-bundle-analyzer": "~2.13.0",
     "webpack-cli": "~2.1.3",
-    "webpack-sources": "~1.1.0"
+    "webpack-sources": "~1.1.0",
+    "@angular-devkit/core": "~0.7.0-beta.1"
   },
   "scripts": {
     "e2e": "tsc -p e2e && mocha --opts ../config/mocha.opts --recursive e2e --appiumCapsLocation ../config/appium.capabilities.json",

e2e/nested-router-tab-view/.gitignore

@@ -0,0 +1,12 @@
+.vscode
+
+platforms
+node_modules
+hooks
+
+/**/*.js
+/**/*.map
+e2e/reports
+test-results.xml
+
+instrumentscli*.trace

e2e/nested-router-tab-view/app/App_Resources/Android/AndroidManifest.xml

@@ -0,0 +1,43 @@
+<?xml version="1.0" encoding="utf-8"?>
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+	package="__PACKAGE__"
+	android:versionCode="1"
+	android:versionName="1.0">
+
+	<supports-screens
+		android:smallScreens="true"
+		android:normalScreens="true"
+		android:largeScreens="true"
+		android:xlargeScreens="true"/>
+
+	<uses-sdk
+		android:minSdkVersion="17"
+		android:targetSdkVersion="__APILEVEL__"/>
+
+	<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
+	<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
+	<uses-permission android:name="android.permission.INTERNET"/>
+
+	<application
+		android:name="com.tns.NativeScriptApplication"
+		android:allowBackup="true"
+		android:icon="@drawable/icon"
+		android:label="@string/app_name"
+		android:theme="@style/AppTheme">
+
+		<activity
+			android:name="com.tns.NativeScriptActivity"
+			android:label="@string/title_activity_kimera"
+			android:configChanges="keyboardHidden|orientation|screenSize"
+			android:theme="@style/LaunchScreenTheme">
+
+			<meta-data android:name="SET_THEME_ON_LAUNCH" android:resource="@style/AppTheme" />
+
+			<intent-filter>
+				<action android:name="android.intent.action.MAIN" />
+				<category android:name="android.intent.category.LAUNCHER" />
+			</intent-filter>
+		</activity>
+		<activity android:name="com.tns.ErrorReportActivity"/>
+	</application>
+</manifest>

e2e/nested-router-tab-view/app/App_Resources/Android/app.gradle

@@ -0,0 +1,16 @@
+// Add your native dependencies here:
+
+// Uncomment to add recyclerview-v7 dependency
+//dependencies {
+//	compile 'com.android.support:recyclerview-v7:+'
+//}
+
+android {  
+  defaultConfig {  
+    generatedDensities = []
+    applicationId = "org.nativescript.nestedroutertabview"  
+  }  
+  aaptOptions {  
+    additionalParameters "--no-version-vectors"  
+  }  
+}