Add Android debug bridge result handler #1678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TsvetanMilanov
force-pushed
the
milanov/add-adb-errors-check
branch
3 times, most recently
from
299a16a to
18f0ad6
Compare
The non-device Android debug bridge must be separated from the device-specific Android debug bridge. The non-device Android debug bridge can be injected through constructor and the device specific Android debug bridge can be resolved using the $injector. This way the device-specific Android debug bridge will be unique for each device.
The adb commands should be executed through the custom adb wrapper to use the error handling.
TsvetanMilanov
force-pushed
the
milanov/add-adb-errors-check
branch
from
18f0ad6 to
fa290bd
Compare
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The android debug bridge result handler checks if there are any errors after executing adb command.
Errors are copied from https://github.com/android/platform_frameworks_base/blob/master/core/java/android/content/pm/PackageManager.java and the handler checks if the result contains any of the errors.
The non-device Android debug bridge must be separated from the device-specific Android debug bridge. Non-device Android debug bridge can be injected through constructor and the device-specific Android debug bridge can be resolved using the $injector. This way the device-specific Android debug bridge will be unique for each device.
The adb commands should be executed through the custom adb wrapper to use the error handling.
Implements #979