Fixed: TNS run command broken with using --watch#2305
Merged
Conversation
Contributor
|
It seems to me that passing boolean parameter to the runPlatform, deployOnDevice and deployOnEmulator overcomplicates the interface. I would suggest separating the methods, so that you can call something like the following in your command Where the deploy method would be responsible only for deploying an application on device/simulator and the startApplication would be responsible only for running an application on device/simulator |
04abe6c to
390853f
Compare
390853f to
d84108e
Compare
PanayotCankov
approved these changes
Dec 8, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2150