Break CLI process when Node is not supported #2320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
changed the title
TsvetanMilanov
approved these changes
Dec 6, 2016
As old versions of Node.js cannot be used anymore (after transpiling to ES6), we should break the process when such case happens. Use only var instead of let, const, as only var keyword is supported in Node.js 0.10.x
rosen-vladimirov
force-pushed
the
vladimirov/strict-node-ver
branch
from
c2aca12 to
93a9c88
Compare
rosen-vladimirov
changed the title
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Merge only after telerik/mobile-cli-lib#851 is merged
EDIT: PR in common is merged, this one can be merged.
As old versions of Node.js cannot be used anymore (after transpiling to ES6), we should break the process when such case happens.
Use only var instead of let, const, as only var keyword is supported in Node.js 0.10.x
Part of #2204