Conversation
TsvetanMilanov
approved these changes
Dec 13, 2016
We use fs.exists, which is deprecated. Change the code to use fs.existsSync instead. This makes the `$fs.exists` method to return boolean instead of `IFuture<boolean>`. Several methods were declared as `IFuture<T>` as in their body they are calling `$fs.exists(...).wait()`. As now the `$fs.exists` method is sync, change all methods that are async only because of `$fs.exists().wait()` sync.
Make emulatorSettingsService.canStart and fs.deleteEmptyParents, fs.isEmptyDir sync
…ompletionService.isAutoCompletionEnabled and IAutoCompletionService.isObsoleteAutoCompletionEnabled sync
…nager.processPlatformSpecificFiles sync
rosen-vladimirov
force-pushed
the
vladimirov/sync-api
branch
from
73520df to
8856e4c
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Merge AFTER telerik/mobile-cli-lib#853
Several methods were declared as
IFuture<T>as in their body they are calling async methods fromfs(for example$fs.exists(...).wait()). As now most of these methods are sync, convert all possible methods to sync (instead of IFuture).