Open specific version of Chrome Dev Tools #2392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enchev
approved these changes
Jan 9, 2017
rosen-vladimirov
approved these changes
Jan 9, 2017
Contributor
rosen-vladimirov
left a comment
rosen-vladimirov
left a comment
There was a problem hiding this comment.
Minor suggestions.
lib/services/ios-debug-service.ts
Outdated
| this._socketProxy = this.$socketProxyFactory.createWebSocketProxy(factory); | ||
|
|
||
| this.$logger.info(`To start debugging, open the following URL in Chrome:\nchrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=localhost:${this._socketProxy.options.port}\n`); | ||
| let commitSHA = "02e6bde1bbe34e43b309d4ef774b1168d25fd024"; // corresponds to 55.0.2883 Chrome version |
Contributor
There was a problem hiding this comment.
you can extract the variable to private static field or const at the top of the file.
Contributor
Author
There was a problem hiding this comment.
I kind of disagree to move it at the top because it is only used in this method. Are you OK with the current version ? It is still a local variable but it's now a const.
lib/services/ios-debug-service.ts
Outdated
|
|
||
| this.$logger.info(`To start debugging, open the following URL in Chrome:\nchrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=localhost:${this._socketProxy.options.port}\n`); | ||
| let commitSHA = "02e6bde1bbe34e43b309d4ef774b1168d25fd024"; // corresponds to 55.0.2883 Chrome version | ||
| this.$logger.info(`To start debugging, open the following URL in Chrome:\nchrome-devtools://devtools/remote/serve_file/@${commitSHA}/inspector.html?experiments=true&ws=localhost:${this._socketProxy.options.port}\n`.cyan); |
Contributor
There was a problem hiding this comment.
os.EOL instead of \n maybe.
Otherwise we would have to update our logic on every Chrome update
KristinaKoeva
force-pushed
the
KristinaKoeva/Chrome
branch
from
7330e88 to
9df13ef
Compare
rosen-vladimirov
approved these changes
Jan 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we would have to update our logic on every Chrome update