Skip to content

Open specific version of Chrome Dev Tools #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KristinaKoeva merged 1 commit into from
Jan 10, 2017
Merged

Open specific version of Chrome Dev Tools #2392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/services/android-debug-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import * as net from "net";
import * as os from "os";
import Future = require("fibers/future");
import { sleep } from "../common/helpers";
import {ChildProcess} from "child_process";
Expand Down Expand Up @@ -236,7 +237,7 @@ class AndroidDebugService implements IDebugService {

private startDebuggerClient(port: Number): IFuture<void> {
return (() => {
this.$logger.info(`To start debugging, open the following URL in Chrome:\nchrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=localhost:${port}\n`);
this.$logger.info(`To start debugging, open the following URL in Chrome:${os.EOL}chrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=localhost:${port}${os.EOL}`.cyan);
}).future<void>()();
}

Expand Down
4 changes: 3 additions & 1 deletion lib/services/ios-debug-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import * as iOSDevice from "../common/mobile/ios/device/ios-device";
import * as net from "net";
import * as path from "path";
import * as log4js from "log4js";
import * as os from "os";
import {ChildProcess} from "child_process";
import byline = require("byline");

Expand Down Expand Up @@ -203,7 +204,8 @@ class IOSDebugService implements IDebugService {
if (this.$options.chrome) {
this._socketProxy = this.$socketProxyFactory.createWebSocketProxy(factory);

this.$logger.info(`To start debugging, open the following URL in Chrome:\nchrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=localhost:${this._socketProxy.options.port}\n`);
const commitSHA = "02e6bde1bbe34e43b309d4ef774b1168d25fd024"; // corresponds to 55.0.2883 Chrome version
this.$logger.info(`To start debugging, open the following URL in Chrome:${os.EOL}chrome-devtools://devtools/remote/serve_file/@${commitSHA}/inspector.html?experiments=true&ws=localhost:${this._socketProxy.options.port}${os.EOL}`.cyan);
} else {
this._socketProxy = this.$socketProxyFactory.createTCPSocketProxy(factory);
this.openAppInspector(this._socketProxy.address()).wait();
Expand Down