Merged
Conversation
rosen-vladimirov
approved these changes
Jan 16, 2017
Contributor
rosen-vladimirov
left a comment
rosen-vladimirov
left a comment
There was a problem hiding this comment.
After green build
Contributor
|
Please describe what's changed in mobile-cli-lib and why it should be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isEmulatormethod was changed to agetproperty.It was initially a
getproperty but was subsequently changed to a method because there were some asynchronous operations in theandroidimplementation.These are no longer necessary so revert the change and make
isEmulatoragetproperty again.Ping @rosen-vladimirov