feat: introduce webpack only workflow #4591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Fatme merged 30 commits into feature/webpack-only from fatme/bundle-workflow

May 17, 2019

Contributor

Fatme commented May 8, 2019

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base
Tests for the changes are included.

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

Fatme added 24 commits

April 25, 2019 10:33

WIP

89c5f6c


          refactor: refactor platform add, platform prepare and platform build …

fb47b68

…workflows


          feat: introduce initialSync workflow

e295df8


          feat: introduce workflowDataService in order to handle the creation o…

3e44606

…f all data related objects in one place


          chore: remove platform-workflow-service

68187de


          chore: add preparePlatformService and remove platformJSService and pl…

eb52dd9

…atformNativeService


          refactor: refactor refreshApplication service

faaf337


          refactor: refactor bundleWorkflowService to mainController

0e4109b


          chore: rename deviceInstallAppService and deviceRefreshAppService so …

73ee306

…the same convention is used for both classes


          refactor: introduce separate run-on-devices-controller

22f594e


          refactor: extract debug specific logic to separate service

64427e9


          chore: emit runOnDeviceStopperEvent

f2caa9d


          feat: add env support to webpackCompilerService

2b8d62c


          feat: add support for fallbackFiles + hmr mode

042a043


          fix: fix deploy command

e85daf7


          fix: remove unneeded interfaces

046d6e9


          feat: stop webpack and native watchers on stopRunOnDevices()

f5f0836


          feat: remove preview-sync hook and integrate preview command to work …

ed8410a

…with new changes


          fix: remove livesyncService

29d7ad9


          fix: fix typo error in debugggingEnabled

4a9c967


          fix: fix mainController tests, delete test/livesync-service and move …

…all appropriate tests from test/livesync-service to main-controller


          refactor: refactor the prepare-platform tests

666044d


          test: fix unit tests

6ba3274


          fix: build the platform when there are native changes on initial sync…

762fcd6

… and add unit tests for that functionality

cla-bot bot added the cla: yes label

ghost assigned Fatme

ghost added the new PR label

Fatme added this to the 6.0.0 milestone

Contributor Author

Fatme commented May 8, 2019

test cli-smoke


          chore: fix lint errors

6769a81

Contributor Author

Fatme commented May 8, 2019

test cli-smoke nativescript-dev-webpack#feature/webpack-only

Contributor Author

Fatme commented May 8, 2019

test cli-smoke nativescript-dev-webpack#webpack

1 similar comment

Contributor Author

Fatme commented May 8, 2019

test cli-smoke nativescript-dev-webpack#webpack

Contributor Author

Fatme commented May 9, 2019

test cli-preview nativescript-dev-webpack#webpack


          chore: fix show the log needed from preview tests

e6c7f98

Contributor Author

Fatme commented May 9, 2019

test cli-preview nativescript-dev-webpack#webpack

1 similar comment

Contributor Author

Fatme commented May 9, 2019

test cli-preview nativescript-dev-webpack#webpack

Fatme force-pushed the fatme/bundle-workflow branch from 1c40b61 to 10c17fb Compare

May 9, 2019 10:50

Contributor Author

Fatme commented May 9, 2019

test cli-preview nativescript-dev-webpack#webpack

Fatme force-pushed the fatme/bundle-workflow branch from 10c17fb to 0a21496 Compare

May 9, 2019 11:05


          fix: fix the initial sync to preview app

66cfacf

Fatme force-pushed the fatme/bundle-workflow branch from 0a21496 to 66cfacf Compare

May 9, 2019 11:16

Contributor Author

Fatme commented May 9, 2019

test cli-preview nativescript-dev-webpack#webpack

1 similar comment

Contributor Author

Fatme commented May 9, 2019

test cli-preview nativescript-dev-webpack#webpack

Fatme force-pushed the fatme/bundle-workflow branch 8 times, most recently from b0b5a94 to 2054946 Compare

May 15, 2019 10:34


          feat: introduce controller for each command

40d5b56

Fatme force-pushed the fatme/bundle-workflow branch from 2054946 to 40d5b56 Compare

May 15, 2019 10:47


          fix: rename platformsData to platformsDataService

4fc6b8e

DimitarTachev approved these changes

View reviewed changes


          fix: fix PR comments

297814e

Fatme merged commit d133c8b into feature/webpack-only

ghost removed the new PR label

Fatme deleted the fatme/bundle-workflow branch

May 17, 2019 07:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels