Skip to content

tests: devtools with loopback host#6013

Merged
NathanWalker merged 2 commits intomainfrom
copilot/fix-unit-tests-chrome-debug-url
Apr 19, 2026
Merged

tests: devtools with loopback host#6013
NathanWalker merged 2 commits intomainfrom
copilot/fix-unit-tests-chrome-debug-url

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 19, 2026

Recent changes left the Android and iOS debug URL tests asserting localhost while the debug service implementation emits 127.0.0.1 in the websocket endpoint. This caused the merged PR to fail in CI despite unchanged runtime behavior.

  • What changed

    • Updated the Chrome debug URL expectations in:
      • test/services/android-device-debug-service.ts
      • test/services/ios-device-debug-service.ts
    • Replaced ws=localhost:<port> with ws=127.0.0.1:<port> across the affected scenarios.
  • Coverage adjusted

    • Bundled DevTools URLs
    • Remote serve_file DevTools URLs
    • HTTP frontend URLs
    • Default and custom devToolsCommit cases
  • Example

    expectedChromeUrl:
    	"devtools://devtools/bundled/inspector.html?ws=127.0.0.1:12345";

Copilot AI and others added 2 commits April 19, 2026 20:51
Agent-Logs-Url: https://github.com/NativeScript/nativescript-cli/sessions/eb6e56c8-2c56-4c35-ae59-4ff2749d2175

Co-authored-by: NathanWalker <457187+NathanWalker@users.noreply.github.com>
Agent-Logs-Url: https://github.com/NativeScript/nativescript-cli/sessions/eb6e56c8-2c56-4c35-ae59-4ff2749d2175

Co-authored-by: NathanWalker <457187+NathanWalker@users.noreply.github.com>
@NathanWalker NathanWalker changed the title Align debug URL unit tests with loopback host behavior tests: devtools with loopback host Apr 19, 2026
@NathanWalker NathanWalker marked this pull request as ready for review April 19, 2026 20:58
@NathanWalker NathanWalker merged commit 229c727 into main Apr 19, 2026
3 checks passed
@NathanWalker NathanWalker deleted the copilot/fix-unit-tests-chrome-debug-url branch April 19, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants