Kddimitrov/extensions #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianDD
force-pushed
the
kddimitrov/extensions
branch
4 times, most recently
from
364d4ff to
f7e2f6e
Compare
KristianDD
force-pushed
the
kddimitrov/extensions
branch
from
f7e2f6e to
64ea6c0
Compare
KristianDD
commented
Mar 19, 2019
| var allNames = {}; | ||
| var regions = {}; | ||
|
|
||
| for (let i = 0; i < files.length; i++) { |
There was a problem hiding this comment.
This part can be extracted in a separate function.
KristianDD
commented
Mar 19, 2019
| isSourceOrHeaderFileType, | ||
| isHeaderFileType | ||
| } | ||
| module.exports = pbxFile; |
rosen-vladimirov
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the library to enable the user to add and remove extensions.