Kddimitrov/fix framework add #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it'll be better to add unit tests for the methods. It is not a merge stopper and can be done in another PR. |
rosen-vladimirov
approved these changes
Mar 22, 2019
KristianDD
force-pushed
the
kddimitrov/fix-framework-add
branch
from
8660874 to
173c323
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing a target if it holds the only reference to the framework it should remove it from the PbxFileReference section and projects Framework PbxGroup.
When removing the variant group, the children name is very likely to collide in FileReference section and the wrong reference is removed. And when removing a group if there is a group collision more than one group will be removed.
All this issues are addressed in this PR.