Fix webpack #39
Merged
Fix webpack #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sis0k0
reviewed
Jun 18, 2017
CONTRIBUTING.md
Outdated
|
|
||
| * Make commits of logical units. | ||
| * Make sure your commit messages are in the proper format. | ||
| * Make sure your commit messages are in the proper format. We are strongly recommend to use [semantic commit messages](https://seesparkbox.com/foundry/semantic_commit_messages) |
| import { config } from "../../app.config"; | ||
| let http = require("http"); | ||
| let appSettings = require("application-settings"); | ||
| let http = require("tns-core-modules/http"); |
Contributor
There was a problem hiding this comment.
you can use 'import' instead of 'require'
| import * as Facebook from "nativescript-facebook"; | ||
| import { NavigationService } from "../../services/navigation.service"; | ||
| let appSettings = require("application-settings"); | ||
| let appSettings = require("tns-core-modules/application-settings"); |
DimitarTachev
approved these changes
Jun 19, 2017
angeltsvetkov
force-pushed
the
fix-webpack
branch
from
995421b to
2485bf6
Compare
angeltsvetkov
force-pushed
the
fix-webpack
branch
from
2485bf6 to
c6434fc
Compare
sis0k0
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.