Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Replaced the Android implementation with the recommended one.#72

Merged
DimitarTachev merged 13 commits intomasterfrom
tachev/location-manager-to-google-play-services
Oct 11, 2017
Merged

Replaced the Android implementation with the recommended one.#72
DimitarTachev merged 13 commits intomasterfrom
tachev/location-manager-to-google-play-services

Conversation

@DimitarTachev
Copy link
Copy Markdown
Contributor

Trying to fix #42 and #62

Replaced the Android Location Manager approach with the Google Play Location Service one (used by Google Maps) as there are a lot of known issues with the Location Manager and it's not the recommended approach for getting a location on Android.

Breaking changes:

  • the isEnabled method returns 'Promise' instead of 'boolean'
  • the updateDistance option is not available for android anymore, use updateTime instead. (A hint from Google - update interval of 5000 milliseconds (5 seconds), causes the location provider to return location updates that are accurate to within a few feet".

@DimitarTachev DimitarTachev merged commit 71fe85f into master Oct 11, 2017
@ghost ghost removed the new PR label Oct 11, 2017
@DimitarTachev DimitarTachev deleted the tachev/location-manager-to-google-play-services branch October 11, 2017 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getCurrentLocation gets timeout on Android API17

2 participants