Fix aspect ratio issue on iOS & add scaling example to docs #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
Author
Contributor
Author
|
@radeva any update? I see the tests passed now... Thanks! |
Contributor
|
Hi @abhayastudios , Thanks for submitting a PR! My concern is that this is changing the current behaviour of the plugin which is a breaking change. We'll use your idea and extend it a bit to add an option where the user can state if he/she want to use AspectFIll or AspectFit. The same way there are options for maxWidth and maxHeight. We'll let you know when this is merged and published. Let us know if this is a working solution for you. Best regards, |
Contributor
Author
|
@radeva keep in mind this is already the default behavior on Android... |
radeva
approved these changes
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix aspect ratio issue on iOS where resized images were filled out instead of maintaining the aspect ratio. Also added example for scaling images to the docs.