feat: flag to skip adding auto-generated component on ng new and ng add
#171
Conversation
sis0k0
left a comment
sis0k0
left a comment
There was a problem hiding this comment.
Hi, Danny! Great work!
I've suggested stylistic changes in some files.
One note about the implementation:
We need to modify the routing module for {N} when the auto-generated component is skipped. We have to make sure that the import and the route are ommited.
Co-Authored-By: d-koppenhagen <mail@d-koppenhagen.de>
…ratedComponent flag has been raised
sis0k0
left a comment
sis0k0
left a comment
There was a problem hiding this comment.
The changes look good! But, there's another problem that I didn't think of initially - the default route redirects to auto-generated, but there's no such route if skipAutoGeneratedComponent is passed.
Actually, there's no component to navigate to.
We should probably leave the routes array empty and replace the page-router-outlet from the AppComponent with a placeholder.
…Component is set or not
|
Hi @sis0k0 that was a good point. I added some conditional checks now. |
sis0k0
changed the title
ng new and ng add
|
test |
sis0k0
changed the title
ng new and ng addng new and ng add
|
Great work! This feature will be included in the next version of |
2 participants
fixes #166