Skip to content

Conversation

@sebawita
Copy link
Contributor

Replace the use of filter() with tree.delete()

This significantly improves the performance of generating components, as filter() is a very slow function, which goes through every single file (including all files in node_modules) to check for the filtering condition.

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

This significantly improves the performance of generating components, as filter() is a very slow function, which goes through every single file (including all files in node_modules) to check for the filtering condition.
@vakrilov vakrilov merged commit c5d6cbd into master Feb 21, 2019
@vakrilov vakrilov deleted the sebawita-slow-generate-fix branch February 21, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants