Skip to content

fix(ng-new): make resolution of lazily-loaded routes consistent between web and mobile #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sis0k0 merged 1 commit into from
Mar 5, 2019
Merged

fix(ng-new): make resolution of lazily-loaded routes consistent between web and mobile #198

sis0k0 merged 1 commit into from
Mar 5, 2019

Conversation

@sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Mar 5, 2019

fixes #197

@cla-bot cla-bot bot added the cla: yes label Mar 5, 2019
@sis0k0 sis0k0 requested review from Mitko-Kerezov and sebawita March 5, 2019 13:05
@sis0k0 sis0k0 self-assigned this Mar 5, 2019
Mitko-Kerezov
Mitko-Kerezov approved these changes Mar 5, 2019
View reviewed changes
Copy link

@Mitko-Kerezov Mitko-Kerezov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all right to me

@sis0k0 sis0k0 merged commit 9b1c31c into master Mar 5, 2019
@sis0k0 sis0k0 deleted the sis0k0/rm-baseurl-web-tsconfig branch March 5, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebawita sebawita Awaiting requested review from sebawita

1 more reviewer

@Mitko-Kerezov Mitko-Kerezov Mitko-Kerezov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sis0k0 sis0k0

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent resolution of lazily-loaded routes in newly generated shared projects

3 participants

@sis0k0 @Mitko-Kerezov