Skip to content

Conversation

@JonJonHuang
Copy link
Contributor

Documented event is not selectedIndexChanged, should be valueChange

Documented event is not selectedIndexChanged, should be valueChange
@cla-bot
Copy link

cla-bot bot commented Feb 17, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @JonJonHuang.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@JonJonHuang JonJonHuang changed the title Update end.md fix: Slider event handler documentation Feb 17, 2020
@JonJonHuang
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Feb 17, 2020
@cla-bot
Copy link

cla-bot bot commented Feb 17, 2020

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Contributor

@NickIliev NickIliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickIliev NickIliev merged commit 5e21dcf into NativeScript:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants