fix: use proper ES Module syntax #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With v4 of the unit test runner, ES Module syntax is mixed with commonJS syntax in a couple of files. As a result, the unit test runner fails to run out of the box with NativeScript v9 because
exports is not defined.This PR updates those files to use proper ES Module syntax throughout, which resolves the error.
Error
Reproduction
Create a new NativeScript Angular application with the following command:
After the project is created, initialize the unit test runner at the root of the project with:
ns test initSelect Jasmine, when prompted. Finally, run the tests on iOS with:
ns test iosThis will present in the error mentioned above.