This repository was archived by the owner on Feb 7, 2019. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 44
improve the demo app and the readme #195
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| ### Make sure to check the demo app(s) for sample usage | ||
|
|
||
| ### Make sure to check the existing issues in this repository | ||
|
|
||
| ### If the demo apps cannot help and there is no issue for your problem, tell us about it | ||
| Please, ensure your title is less than 63 characters long and starts with a capital | ||
| letter. | ||
|
|
||
| ### Which platform(s) does your issue occur on? | ||
| - iOS/Android/Both | ||
| - iOS/Android versions | ||
| - emulator or device. What type of device? | ||
|
|
||
| ### Please, provide the following version numbers that your issue occurs with: | ||
|
|
||
| - CLI: (run `tns --version` to fetch it) | ||
| - Cross-platform modules: (check the 'version' attribute in the | ||
| `node_modules/tns-core-modules/package.json` file in your project) | ||
| - Runtime(s): (look for the `"tns-android"` and `"tns-ios"` properties in the `package.json` file of your project) | ||
| - Plugin(s): (look for the version numbers in the `package.json` file of your | ||
| project and paste your dependencies and devDependencies here) | ||
|
|
||
| ### Please, tell us how to recreate the issue in as much detail as possible. | ||
| Describe the steps to reproduce it. | ||
|
|
||
| ### Is there any code involved? | ||
| - provide a code example to recreate the problem | ||
| - (EVEN BETTER) provide a .zip with application or refer to a repository with application where the problem is reproducible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,20 +15,23 @@ app.on(app.resumeEvent, function(args) { | |
| const act = args.android; | ||
| const intent = act.getIntent(); | ||
| const extras = intent.getExtras(); | ||
| console.log("Resuming activity"); | ||
| if (extras) { | ||
| console.log("If your notification has data (key: value) pairs, they will be listed here:"); | ||
| const keys = extras.keySet(); | ||
| const iterator = keys.iterator(); | ||
| while (iterator.hasNext()) { | ||
| const key = iterator.next(); | ||
| console.log(key + ": " + extras.get(key).toString()); | ||
| // clear the used keys in order to avoid getting them back | ||
| // when manually switching the application between background and foreground | ||
| intent.removeExtra(key); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure if all extras are set by the FCM SDK |
||
| } | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| app.start({ moduleName: 'main-page' }); | ||
|
|
||
| /* | ||
| Do not place any code after the application has been started as it will not | ||
| be executed on iOS. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want to keep consistent with the rest of the file, ordered lists should be 1 1 1 and not 1 2 3