Changes on index.html#127
Merged
amitguptagwl merged 2 commits intoNaturalIntelligence:masterfrom Nov 9, 2018
Merged
Conversation
added 2 commits
November 8, 2018 11:39
Changed all .text() jQuery calls to .val() as this new function continues to work even after the user has typed/changed something on the textarea.
Changed demo_spec file to work with the new changed on index.html
Author
|
Updated the demoapp_spec.js file as it didn't recognize the formatted content. I see all tests are passing but there seems to be something not working with the security validator. |
Member
|
security validator? |
Author
|
The CI tool runs 3 tasks, I can see there is one called security-something that fails, but seems to be a problem with the tool itself. |
Member
|
@lfplazas10 Sorry but I'm not able to link your words. I couldn't find anything like "security*" in the whole repository. Can you please share the screenshot? I believe you're separately working on JSOn to XML parsing demo. |
Author
|
I was talking about the security/snyk check performed by the CI tool. |
Member
|
Ah ok. I got your point. Thanks. That's not an issue. So ignore that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was working on #79 I noticed that if the user changes something on the result textarea, any further Convert or Validate calls did not update the textarea content. The solution for this was quite simple, just had to change all$.text() calls to $ .val()