fix #89,fix #90, fix #91 Refactored buildOptions, fixed bug with BOM and added support non-english characters in validator#92
Merged
amitguptagwl merged 7 commits intoNaturalIntelligence:masterfrom May 15, 2018
Conversation
1 similar comment
amitguptagwl
requested changes
May 15, 2018
|
|
||
| const tags = []; | ||
| let tagFound = false; | ||
| if (xmlData[0] === "\ufeff") { |
Member
There was a problem hiding this comment.
Please add a comment "check for byte order mark (BOM)"
Member
|
Thanks for the PR. Will publish changes after generating the browser bundle soon. |
Contributor
Author
|
I hope you didn't forget about publish new version on npm?:relaxed: |
Member
|
I think I've forgot. Let me check 🤦♂️ |
Member
|
done |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
Corrected returning value defaultOptions in buildOptions function instead of set every newOptions from defaultOptions in loop when there are not user's options. I think it give a little bit rise of perfomance (fix #89). Fixed bug in validation when XML data with byte order marker (BOM) (fix #90). Added support of non-english characters in XML validation (fix #91).
Type
Enhancement, refactoring, bug fix
[x]Bug Fix
[x]Refactoring / Technology upgrade
[x]New Feature