Upgrade dependencies and modernize testing infrastructure#767
Upgrade dependencies and modernize testing infrastructure#767JustinBeckwith wants to merge 2 commits intoNaturalNode:masterfrom
Conversation
- Upgrade webpack 4 -> 5 with proper Node.js polyfill configuration - Upgrade jasmine 3 -> 6 and fix duplicate test names - Upgrade TypeScript to 5.9.3 - Replace gulp-based browser testing with jasmine-browser-runner - Remove unused dependencies: standard, ts-standard, gulp, gulp-jasmine-browser, inherits - Configure webpack to use browserify util polyfill for browser compatibility - Reduce npm vulnerabilities from 23 to 0 - All 868 specs passing in both Node.js and browser environments Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Thanks. I have to say that, while you generated this PR using AI, I now have to check all changes by hand before I can give the go ahead for merging it. |
Pull Request Test Coverage Report for Build 21784494255Details
💛 - Coveralls |
- Fix template literal lint errors in test files (SentimentAnalyzer_spec, hamming_distance_spec) - Enable type-aware linting by adding parserOptions.project to .eslintrc.json - Add npm run fix script for easy auto-fixing of lint issues This ensures local ESLint catches the same issues as CI's ts-standard linter. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
I am going to close this PR because it proposes all kinds of changes that have nothing to do with modernisation. This is caused by the fact that this is an automatically generated PR. Please refrain from making PR's with AI. It costs a lot of time to analyse the changes an AI proposes. Furthermore we need to take the modernisation of the testing and dependencies step by step to make sure everything keeps working. |
|
Believe me, I can appreciate the impact AI generated PRs on open source projects. However ... this actually does have a fair bit to do with modernization. You're sitting on a ton of out of date dependencies at dev time that have numerous reported and verified vulnerabilities. Yes, I happened to use an agent to do this - but I reviewed every change it made, and stand by the changes I made. I suspect if I submitted this PR with a human written description, and didn't outright disclose I used claude to write it - nothing in here would be problematic. Of course, this is your project, and y'all should run it how you see fit, but I'd encourage you to have a closer look 🤷 |
Greetings folks, and thanks for the wonderful library! I was trying to chase down a deprecation warning in my own library, and it was a transitive dependency on
http-server. Turns out ... you weren't using it!While I was in here, figured I'd burn some tokens upgrading your dev infrastructure and getting rid of all those deprecation and security warnings :)
Feedback welcomed!
Summary
This PR upgrades major dev dependencies, modernizes the browser testing infrastructure, and achieves zero npm vulnerabilities.
Changes
Dependency Upgrades
Testing Infrastructure
utilpolyfill for proper browser compatibilityspec/support/jasmine-browser.jsonconfigurationDependency Cleanup
Removed unused dependencies:
standard(redundant with eslint)ts-standard(redundant with @typescript-eslint)gulpandgulp-jasmine-browser(replaced with jasmine-browser-runner)inherits(transitive dependency, not directly used)Jasmine 6 Compatibility
Fixed duplicate test suite and spec names to comply with Jasmine 6's strict duplicate checking:
Security
Test Results
Breaking Changes
None - all tests pass and the API remains unchanged.
🤖 Generated with Claude Code