Skip to content

Fix release workflow to improve commithelper-go publishing logic and streamline asset upload conditions#55

Merged
yujeong-jeon merged 1 commit intomainfrom
ci/rc-publish
Feb 6, 2026
Merged

Fix release workflow to improve commithelper-go publishing logic and streamline asset upload conditions#55
yujeong-jeon merged 1 commit intomainfrom
ci/rc-publish

Conversation

@yujeong-jeon
Copy link
Contributor

@yujeong-jeon yujeong-jeon commented Feb 6, 2026

Related Issue

  • #

Describe your changes

Related Issue

  • Fixes issues with canary/RC publish not creating releases and uploading assets for commithelper-go

Describe your changes

This PR fixes the release workflow to properly handle canary/RC publishing and asset uploads for the commithelper-go package.

Key changes:

  1. Fixed duplicate step IDs: Added unique IDs to each publish step (publish_release, publish_canary, publish_rc)
  2. Moved package check to post-publish: Changed from checking if package exists in npm before publishing to checking what was actually published
  3. Use publishedPackages output: Now parses the publishedPackages output from publish actions to determine if commithelper-go was published
  4. Always create releases for canary/RC: Set create_release: true for canary publishes (was conditionally false before)
  5. Improved upload-assets conditions: Added published == 'true' check to ensure publish succeeded before uploading assets

Problem solved:

Before this change:

  • The workflow checked if the base version (e.g., 1.0.0) exists in npm
  • Canary/RC versions use dynamic versioning (e.g., 1.0.0-rc.20260206-abc1234)
  • If base version already existed, commithelperGoWillBePublished was false
  • Result: No releases created and no assets uploaded for canary/RC publishes ❌

After this change:

  • The workflow checks the actual published packages from the publish action output
  • If commithelper-go was published (regardless of version type), assets are uploaded ✅

Request

Please review:

  • The logic in the "Check if commithelper-go was published" step (lines 131-142)
  • The updated job outputs (line 39)
  • The new upload-assets condition (line 146)

Copy link
Collaborator

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

영웅은 죽지 않아요~~

@yujeong-jeon
Copy link
Contributor Author

난죽택

@yujeong-jeon yujeong-jeon merged commit 145ea8e into main Feb 6, 2026
3 of 4 checks passed
@yujeong-jeon yujeong-jeon deleted the ci/rc-publish branch February 6, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants