Skip to content

pite 최신화#217

Merged
yceffort-naver merged 6 commits intomainfrom
chore/update-pite
Apr 28, 2025
Merged

pite 최신화#217
yceffort-naver merged 6 commits intomainfrom
chore/update-pite

Conversation

@keemhyunseok
Copy link
Contributor

@keemhyunseok keemhyunseok commented Feb 25, 2025

펍린트 에러 발생

1. publint main, module, types 필드

image
  • 별도 entry 배럴파일 없는 hidash에서 위 세 필드를 어떻게 처리해야할지?
  • entry index.ts를 추가해 위 세 필드에 적용?

publint에 skip 옵션 추가

2. export 경로 문제

image
  • 빌드는 문제없이 잘 되는 것으로 보임
image
  • 빌드 후 publint 에러 표시. package.json의 export필드의 경로를 ./module.js 형태로 작성한 것에서 에러발생
  • ./dist/module.js 형태로 작성해서 문제를 해결해도 되는지?

loose, strict 옵션 받아서

@keemhyunseok keemhyunseok self-assigned this Feb 25, 2025
@keemhyunseok keemhyunseok requested a review from a team as a code owner February 25, 2025 02:27
@npayfebot
Copy link
Collaborator

npayfebot commented Feb 25, 2025

✅ Changeset detected

Latest commit: 90c4202

@naverpay/hidash package have detected changes.

If no version change is needed, please add skip-detect-change to the label.

The changes in this PR will be included in the next version bump.

powered by: naverpay changeset detect-add actions

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

✅ All utility modules are properly registered in index.ts and package.json exports!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Benchmark Results

Method Test Performance Comparison hidash ops/sec lodash@4.17.21 ops/sec
clone src/clone.bench.ts > clone performance hidash is 16.71x faster 55.30 🏆 3.31
toPairs src/toPairs.bench.ts > toPairs performance hidash is 2.97x faster 93.52 🏆 31.50

Note: Higher operations per second (ops/sec) numbers are better. Each test compares hidash vs lodash implementation.

⚠️ indicates where hidash is slower than lodash.

🏆 indicates the faster implementation.

View Full Benchmark Data
{
  "files": [
    {
      "filepath": "/home/runner/work/hidash/hidash/src/clone.bench.ts",
      "groups": [
        {
          "fullName": "src/clone.bench.ts > clone performance",
          "benchmarks": [
            {
              "id": "-1512290311_0_0",
              "name": "hidash",
              "rank": 1,
              "rme": 0.3426765965048654,
              "samples": [],
              "totalTime": 506.362763,
              "min": 17.90142800000001,
              "max": 18.616434000000027,
              "hz": 55.296325176264986,
              "period": 18.084384392857142,
              "mean": 18.084384392857142,
              "variance": 0.02553757571639489,
              "sd": 0.15980480504789238,
              "sem": 0.030200269462134468,
              "df": 27,
              "critical": 2.052,
              "moe": 0.06197095293629993,
              "p75": 18.12143500000002,
              "p99": 18.616434000000027,
              "p995": 18.616434000000027,
              "p999": 18.616434000000027,
              "sampleCount": 28,
              "median": 18.061384000000032
            },
            {
              "id": "-1512290311_0_1",
              "name": "lodash",
              "rank": 2,
              "rme": 1.9342138789327976,
              "samples": [],
              "totalTime": 3022.39195,
              "min": 288.86693600000035,
              "max": 311.3686310000003,
              "hz": 3.308637716560885,
              "period": 302.239195,
              "mean": 302.239195,
              "variance": 66.79213979436504,
              "sd": 8.172645825824404,
              "sem": 2.5844175319472864,
              "df": 9,
              "critical": 2.262,
              "moe": 5.845952457264762,
              "p75": 309.9658809999992,
              "p99": 311.3686310000003,
              "p995": 311.3686310000003,
              "p999": 311.3686310000003,
              "sampleCount": 10,
              "median": 302.65040299999964
            }
          ]
        }
      ]
    },
    {
      "filepath": "/home/runner/work/hidash/hidash/src/toPairs.bench.ts",
      "groups": [
        {
          "fullName": "src/toPairs.bench.ts > toPairs performance",
          "benchmarks": [
            {
              "id": "-742651752_0_0",
              "name": "hidash",
              "rank": 1,
              "rme": 1.5513938169962005,
              "samples": [],
              "totalTime": 502.5882509999997,
              "min": 10.324018999999907,
              "max": 14.278622999999925,
              "hz": 93.51591468062398,
              "period": 10.693367042553184,
              "mean": 10.693367042553184,
              "variance": 0.3189614854878996,
              "sd": 0.5647667531715191,
              "sem": 0.08237969764965715,
              "df": 46,
              "critical": 2.0138,
              "moe": 0.16589623512687957,
              "p75": 10.720496000000026,
              "p99": 14.278622999999925,
              "p995": 14.278622999999925,
              "p999": 14.278622999999925,
              "sampleCount": 47,
              "median": 10.622322999999994
            },
            {
              "id": "-742651752_0_1",
              "name": "lodash",
              "rank": 2,
              "rme": 0.16256441474417166,
              "samples": [],
              "totalTime": 507.92897900000025,
              "min": 31.62562200000002,
              "max": 31.924897999999985,
              "hz": 31.500466918624053,
              "period": 31.745561187500016,
              "mean": 31.745561187500016,
              "variance": 0.00938361261669406,
              "sd": 0.0968690488065928,
              "sem": 0.0242172622016482,
              "df": 15,
              "critical": 2.131,
              "moe": 0.05160698575171231,
              "p75": 31.79887400000007,
              "p99": 31.924897999999985,
              "p995": 31.924897999999985,
              "p999": 31.924897999999985,
              "sampleCount": 16,
              "median": 31.728247500000066
            }
          ]
        }
      ]
    }
  ]
}

Last updated by GitHub Actions

@keemhyunseok
Copy link
Contributor Author

@yceffort-naver#217 (comment) publint적용에 따른 두 문제가 발생하는데 제가 생각한 방향으로 수정해도 되는걸까요?

@yceffort-naver
Copy link
Contributor

이거는 한번 회의 해볼까여? @byhhh2 @2-one-week @keemhyunseok

@keemhyunseok
Copy link
Contributor Author

네넹

@yceffort-naver yceffort-naver marked this pull request as draft February 25, 2025 04:52
@byhhh2
Copy link

byhhh2 commented Feb 25, 2025

앗 이런..

@yceffort-naver
Copy link
Contributor

@keemhyunseok 님, 휴가가시기전에 이것만~~~

isEmpty의 추정되는 타입 never 때문에 isString, isArray 추정이 안되는 문제 해결
@keemhyunseok keemhyunseok marked this pull request as ready for review March 31, 2025 06:40
@keemhyunseok
Copy link
Contributor Author

@yceffort-naver 님,
Validate Utils Registration 이건 뭔가요?

Copy link
Contributor

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

머지하겠습니다!

@yceffort-naver yceffort-naver merged commit 2dd676e into main Apr 28, 2025
6 checks passed
@yceffort-naver yceffort-naver deleted the chore/update-pite branch April 28, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants