search 파라미터 이중 인코딩 제거#35
Merged
yongholeeme merged 3 commits intomainfrom Oct 24, 2024
Merged
Conversation
yongholeeme
requested review from
a team,
bokdol-soohyeon and
yceffort-naver
as code owners
🦋 Changeset detectedLatest commit: 95cf37d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yceffort
reviewed
Oct 24, 2024
Comment on lines
-229
to
+230
| const encodedSearch = encodeURI(search) | ||
| this._search = encodedSearch.startsWith('?') ? encodedSearch : `?${encodedSearch}` | ||
| this._searchParams = new URLSearchParams(encodedSearch) | ||
| this._search = search.startsWith('?') ? search : `?${search}` | ||
| this._searchParams = new URLSearchParams(search) |
Contributor
Author
There was a problem hiding this comment.
searchParams 는 내부적으로 하고 있어서 객체 생성할 때, search 인코딩을 하고 있어서 여기서 두 번 하고 있었습니다.
(setter에서는 필요없었음)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.