Conversation
# Conflicts: # src/App.tsx
…nglish translation
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…igration Agent-Logs-Url: https://github.com/NaviAndrei/PromptLibrary/sessions/bd54c7c0-8efd-40cd-91e7-952291a5c184 Co-authored-by: NaviAndrei <85543388+NaviAndrei@users.noreply.github.com>
…geUsage Agent-Logs-Url: https://github.com/NaviAndrei/PromptLibrary/sessions/d9681aa7-ace5-4a76-be9f-95084318ca04 Co-authored-by: NaviAndrei <85543388+NaviAndrei@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Release-related update that improves sidebar scrolling behavior and expands template variable parsing to support hints and more permissive variable names.
Changes:
- Make the left sidebar independently scrollable and add a minimal custom scrollbar.
- Update variable extraction/injection + template variable detection to support
{{var=hint}}and more flexible variable names. - Bump package version and add changelog entries for 1.2.6–1.2.8.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/index.css |
Sidebar becomes a bounded scroll container; adds custom scrollbar styling. |
src/components/VariableInjector.tsx |
More permissive variable regex; supports hints and uses them as input placeholders. |
src/components/TemplateManager.tsx |
Updates variable-detection regex to match new variable syntaxes. |
package.json |
Version bump to 1.2.8. |
CHANGELOG.md |
Adds entries for 1.2.6–1.2.8. |
Comments suppressed due to low confidence (1)
src/components/VariableInjector.tsx:213
- Variable names now allow whitespace (
[\w\s-]+), butaria-describedby/idvalues are built fromv.name. Ifv.namecontains spaces, the generated id (e.g.variable-help-My Var) is invalid HTML and will break the ARIA association. Please sanitizev.namefor use in element IDs (e.g., replace whitespace with '-') or generate a separate stable, safe id.
aria-label={`Enter value for variable ${v.name}`}
aria-describedby={`variable-help-${v.name}`}
/>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (fullHint.includes(':')) { | ||
| const parts = fullHint.split(':'); | ||
| typeHint = parts[0].toLowerCase(); | ||
| optionsRaw = parts.slice(1).join(':'); | ||
| } else if (fullHint && !fullHint.includes('=') && TYPE_MAP[fullHint.toLowerCase()]) { |
There was a problem hiding this comment.
extractVariables treats any fullHint containing ':' as type/options syntax, even when the variable used '=' hint syntax (e.g. {{var=Hint: with colon}}). This causes the hint to be mis-parsed and dropped. Consider capturing the delimiter in the regex (':' vs '=') and only parsing type/options when the delimiter is ':', leaving '=' hints intact even if they contain colons.
| "private": false, | ||
| "description": "A modern, sleek web application for managing AI prompts. Built with React, TypeScript, and Vite.", | ||
| "version": "1.2.5", | ||
| "version": "1.2.8", | ||
| "author": "Ivan Andrei (NaviAndrei)", |
There was a problem hiding this comment.
PR title indicates a v1.2.5 release, but package.json is bumping to 1.2.8. Please align the PR title/release branch naming and the version/changelog so the release automation and tagging are consistent.
| - Rezolvat conflictele de compilare (Vite 8 Rolldown) și fixat tipabilitățile TypeScript din zona de căutare hibridă FlexSearch. | ||
| - Fixat dependențele peer conflictuale la integrarea modulului `vite-plugin-pwa` offline. | ||
| - Adăugat suport pentru persistența datelor migratoare `prompt-history` printr-un fix minor de compatibilitate pentru hook-urile React (`useIndexedDB`). |
There was a problem hiding this comment.
The 1.2.6 changelog entry lists multiple fixes (Vite/Rolldown compile conflicts, FlexSearch typings, peer deps, IndexedDB hook compatibility) that are not part of this PR diff. Please ensure each changelog entry matches the actual code included in the corresponding version (move/remove items as needed), and keep language consistent with the rest of the changelog.
| - Rezolvat conflictele de compilare (Vite 8 Rolldown) și fixat tipabilitățile TypeScript din zona de căutare hibridă FlexSearch. | |
| - Fixat dependențele peer conflictuale la integrarea modulului `vite-plugin-pwa` offline. | |
| - Adăugat suport pentru persistența datelor migratoare `prompt-history` printr-un fix minor de compatibilitate pentru hook-urile React (`useIndexedDB`). |
No description provided.