Fix skipping dialog bug in F4VR and add player skipping and exiting dialog features#1
Open
ArthurHub wants to merge 3 commits intoNeanka:masterfrom
Open
Fix skipping dialog bug in F4VR and add player skipping and exiting dialog features#1ArthurHub wants to merge 3 commits intoNeanka:masterfrom
ArthurHub wants to merge 3 commits intoNeanka:masterfrom
Conversation
- ProcessUserEvent up has special handling in swf that causes the skip - No idea why it's there, no reason to send up event in general IMO
- Works for starting, middle, and end of conversations! Note: requires making "onNeutralRelease" public in DialogueMenu.swf
- exists the dialog without the need to walk away - works on all dialogs, including some dialog scenes that have higher distance values than default ini - I RE the use of the option to find code that includes both - Returning a low value from the hook exits all dialogs in the game
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires update to
DialogueMenu.swfonNeutralReleasepublic