Bugfix, Tooltips and minimap indicator#529
Merged
sp00ktober merged 13 commits intoNebulaModTeam:masterfrom Mar 9, 2022
Merged
Conversation
…disconnecting because of host error System.ObjectDisposedException
…exOutOfBounds errors.
…by planet surface
… player). listing players command also displays their id now. minimap player name is darker when on the other side of the planet.
PhantomGamers
requested changes
Mar 9, 2022
Collaborator
PhantomGamers
left a comment
PhantomGamers
left a comment
There was a problem hiding this comment.
If you trigger a tooltip to pop up and then close the menu, the tooltip persists on the screen indefinitely
Also I think the /system command should use the system the player is currently in (if they are in one) if it is used without any arguments.
Other than those two things this looks good!
limoka
suggested changes
Mar 9, 2022
| public string GetUsage() | ||
| { | ||
| return "[planet name | planet id | star name | star id | clear | player] [player id | playr name]"; | ||
| return "[planet name | planet id | star name | star id | clear]\r\nUsage: /n player [player id | playr name]"; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
limoka
suggested changes
Mar 9, 2022
| { | ||
| sb.Append($"Usage: {FullCommandName(commandName)} {usage}\n"); | ||
| } | ||
| string usageString = sb.ToString(); |
Contributor
There was a problem hiding this comment.
This is a weird way of doing this. Move iterations down and save one string variable allocated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far contains:
System.ObjectDisposedExceptionon host resulting in random client disconnectPlanetFactory.Import()