feat(dev-workflow): PR C — real feature pipeline (build/test/ship)#222
feat(dev-workflow): PR C — real feature pipeline (build/test/ship)#222Neftedollar merged 2 commits intomasterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6947d5e31b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| passed: exitCode === 0, | ||
| output: combinedOutput, | ||
| exitCode: exitCode ?? -1, |
There was a problem hiding this comment.
This task records exitCode !== 0 as passed: false but still returns normally, which means the executor treats TEST as successful and continues to verify/ship (function tasks only stop the DAG when they throw). In any run where bun test fails, the pipeline can still open a PR if the reviewer gate is approved, so the TEST stage is not acting as a hard quality gate.
Useful? React with 👍 / 👎.
| build: { | ||
| output: { filesChanged: readonly string[]; summary: string }; | ||
| }; |
There was a problem hiding this comment.
The build agent emits typecheckPassed, but this value is dropped when wiring ship inputs, so SHIP has no deterministic check for typecheck failure. If BUILD reports typecheckPassed: false, the workflow can still push and create a PR as long as verify returns APPROVED, which allows non-typechecking code to be shipped.
Useful? React with 👍 / 👎.
Swaps 3 noop nodes in feature.ts for real implementations: - build: defineAgent using engineering-senior-developer role (codex) - test: defineFunction spawning bun test with 10min timeout - ship: defineFunction — git + gh pr create (no hardcoded --base) Session on build deferred to PR D where fix→test iteration needs it. Bumps @ageflow/dev-workflow 0.0.11 → 0.0.12 (private).
CI flagged a multi-line format preference on the git add catch block.
Neftedollar
force-pushed
the
feat/dev-workflow-feature-pipeline-real
branch
from
288767b to
d5d61cd
Compare
1 participant
Summary
Third of 5 PRs implementing
dev-run.md. Makes the feature pipeline end-to-end real.Changes
pipelines/feature.ts: build → senior-developer agent, test →bun testdefineFunction, ship → git/gh defineFunctionTest plan
--dry-run 194worksRefs #194