feat(dev-workflow): stream live progress in run.ts (#234)#235
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a2aa028bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| startedAt !== undefined ? ev.timestamp - startedAt : ev.metrics.latencyMs; | ||
| state.starts.delete(ev.taskName); | ||
|
|
||
| state.spentUsd += ev.metrics.estimatedCost; |
There was a problem hiding this comment.
Include halted-task cost in spent budget tracking
state.spentUsd is updated only in the task:complete branch, but this workflow sets budget.onExceed to "halt", and the executor checks budget after adding task cost but before emitting task:complete. When a task pushes spend over cap, execution goes through task:error without a matching task:complete, so the progress UI under-reports actual spend and can skip the intended 80% warning on that failure path.
Useful? React with 👍 / 👎.
Summary
Validation
Closes #234