Skip to content

feat(dev-workflow): stream live progress in run.ts (#234)#235

Open
Neftedollar wants to merge 1 commit intomasterfrom
feat/234-dogfood-runts-uses-executorrun-no-progress-visible-during-10-30min-runs
Open

feat(dev-workflow): stream live progress in run.ts (#234)#235
Neftedollar wants to merge 1 commit intomasterfrom
feat/234-dogfood-runts-uses-executorrun-no-progress-visible-during-10-30min-runs

Conversation

@Neftedollar
Copy link
Copy Markdown
Owner

Summary

  • switch dev-workflow live execution from blocking run() to streamed progress output
  • print task start/complete/error lines with durations and cost tracking
  • add dedicated unit tests for progress rendering/stream draining
  • update dev-workflow README status and live-run behavior notes

Validation

  • bun run --filter @ageflow/dev-workflow typecheck
  • bun run --filter @ageflow/dev-workflow test
  • bun run --filter @ageflow/dev-workflow lint

Closes #234

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0a2aa028bf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

startedAt !== undefined ? ev.timestamp - startedAt : ev.metrics.latencyMs;
state.starts.delete(ev.taskName);

state.spentUsd += ev.metrics.estimatedCost;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include halted-task cost in spent budget tracking

state.spentUsd is updated only in the task:complete branch, but this workflow sets budget.onExceed to "halt", and the executor checks budget after adding task cost but before emitting task:complete. When a task pushes spend over cap, execution goes through task:error without a matching task:complete, so the progress UI under-reports actual spend and can skip the intended 80% warning on that failure path.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dogfood: run.ts uses executor.run() — no progress visible during 10-30min runs

1 participant