Skip to content

fix: 필요 없는 코드 수정#16

Merged
surfwithus merged 11 commits intomainfrom
feat/signup
Jul 15, 2025
Merged

fix: 필요 없는 코드 수정#16
surfwithus merged 11 commits intomainfrom
feat/signup

Conversation

@surfwithus
Copy link
Copy Markdown
Collaborator

@surfwithus surfwithus commented Jul 15, 2025

Summary by CodeRabbit

  • 신규 기능

    • 가족 생성 및 가족 코드 발급, 가족 코드로 가입 기능이 추가되었습니다.
    • 가족 관련 서비스 및 토큰 저장 기능이 새롭게 도입되었습니다.
  • 버그 수정 및 개선

    • 회원가입 단계별 화면의 입력값 검증 및 안내 메시지 스타일이 개선되었습니다.
    • 이메일, 이름, 가족명 입력 시 잘못된 입력에 대한 안내가 더 명확하고 보기 좋게 변경되었습니다.
    • 가족 코드 생성 및 가입, 회원가입 플로우가 더 간단하고 직관적으로 개선되었습니다.
  • UI/UX 개선

    • 안내 스낵바의 색상, 배경, 둥근 모서리 등 시각적 요소가 개선되었습니다.
    • 일부 버튼 및 텍스트의 크기, 정렬, 패딩이 조정되어 더 깔끔한 화면을 제공합니다.
  • 기타

    • 내부 서비스 클래스 명칭이 변경되고, 코드 구조가 정리되었습니다.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jul 15, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

회원가입 및 가족 코드 생성/참여 플로우가 대폭 리팩토링되었습니다. 기존의 AuthService 기반 회원가입 로직이 SignupService, CodeService, FamilyJoinService 등으로 분리되었고, 토큰 관리를 위한 TokenStorage 유틸이 추가되었습니다. 각 스크린의 UI 및 에러 메시지 스타일도 개선되었습니다.

Changes

파일/그룹 변경 요약
.../signup/familycode_create_screen.dart AuthService → CodeService로 변경, 가족 코드 생성만 담당하도록 리팩토링, UI 및 버튼 동작 개선
.../signup/familycode_screen.dart FamilyJoinService 도입, 가족 코드 입력 후 참여 로직 단순화, 에러 메시지 및 로딩 처리 개선
.../signup/familyname_screen.dart 회원가입 로직 제거, 가족 이름만 저장, 체크박스 UI 위치 및 스타일 수정, 에러 메시지 스타일 개선
.../signup/mode_screen.dart _setModeAndNavigate → _setModeAndRegister, 회원가입/로그인 절차 통합, 예외 처리 및 네비게이션 개선
.../signup/ready_screen.dart 텍스트 및 버튼 스타일 조정, 레이아웃 간소화
.../signup/username_screen.dart 빈 입력 시 Snackbar 스타일 개선
.../start_screen.dart 이메일 입력 검증 강화(한글 포함 여부), Snackbar 스타일 개선
.../services/code_service.dart CodeService 신설, 가족 생성 API 연동 메서드 추가
.../services/family_join_service.dart FamilyJoinService 신설, 가족 참여 API 연동 메서드 추가
.../services/signup_service.dart AuthService → SignupService로 클래스명 변경
.../utils/token_storage.dart TokenStorage 유틸 신설, 액세스 토큰 저장/조회/삭제 기능 추가
.../services/email_service.dart import 순서 변경(기능 변화 없음)

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ModeScreen
    participant SignupService
    participant LoginService
    participant FamilynameScreen
    participant TokenStorage

    User->>ModeScreen: 부모/자녀 선택
    ModeScreen->>SignupService: register(email, pw, name, mode)
    SignupService-->>ModeScreen: 회원가입 결과
    ModeScreen->>LoginService: login(email, pw)
    LoginService-->>TokenStorage: accessToken 저장
    ModeScreen->>FamilynameScreen: 네비게이션
Loading
sequenceDiagram
    participant User
    participant FamilynameScreen
    participant SharedPreferences
    participant FamilycodeCreateScreen
    participant CodeService

    User->>FamilynameScreen: 가족 이름 입력
    FamilynameScreen->>SharedPreferences: family_name 저장
    FamilynameScreen->>FamilycodeCreateScreen: 네비게이션
    User->>FamilycodeCreateScreen: "생성하기" 클릭
    FamilycodeCreateScreen->>CodeService: familyCreate(family_name)
    CodeService-->>FamilycodeCreateScreen: 가족 코드 반환
    FamilycodeCreateScreen->>User: 코드 표시
Loading
sequenceDiagram
    participant User
    participant FamilycodeScreen
    participant FamilyJoinService
    participant ReadyScreen

    User->>FamilycodeScreen: 가족 코드 입력
    FamilycodeScreen->>FamilyJoinService: familyJoin(code)
    FamilyJoinService-->>FamilycodeScreen: 결과 반환
    FamilycodeScreen->>ReadyScreen: 네비게이션(성공 시)
Loading

Possibly related PRs

Poem

🥕
새로운 가족 코드, 토끼도 신이 나,
버튼을 누르면 코드가 짜잔!
회원가입은 서비스가 척척,
토큰은 저장소에 쏙쏙,
오렌지빛 스낵바가 반짝,
온기 가득한 우리 집,
토끼도 함께 뛰놀아요!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 588d6a9 and e9a6a90.

📒 Files selected for processing (12)
  • frontend/ongi/lib/screens/signup/familycode_create_screen.dart (4 hunks)
  • frontend/ongi/lib/screens/signup/familycode_screen.dart (3 hunks)
  • frontend/ongi/lib/screens/signup/familyname_screen.dart (3 hunks)
  • frontend/ongi/lib/screens/signup/mode_screen.dart (3 hunks)
  • frontend/ongi/lib/screens/signup/ready_screen.dart (1 hunks)
  • frontend/ongi/lib/screens/signup/username_screen.dart (1 hunks)
  • frontend/ongi/lib/screens/start_screen.dart (1 hunks)
  • frontend/ongi/lib/services/code_service.dart (1 hunks)
  • frontend/ongi/lib/services/email_service.dart (1 hunks)
  • frontend/ongi/lib/services/family_join_service.dart (1 hunks)
  • frontend/ongi/lib/services/signup_service.dart (1 hunks)
  • frontend/ongi/lib/utils/token_storage.dart (1 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@surfwithus surfwithus merged commit 7523b50 into main Jul 15, 2025
2 of 3 checks passed
@surfwithus surfwithus deleted the feat/signup branch July 15, 2025 10:09
Neibce pushed a commit to 2025-PNU-SW-Hackathon/PNUSW-2025-OnGi-10 that referenced this pull request Aug 25, 2025
* fix: 필요 없는 코드 수정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant