Skip to content

feat: light background 및 color 추가#23

Merged
surfwithus merged 1 commit intomainfrom
feat/background
Jul 16, 2025
Merged

feat: light background 및 color 추가#23
surfwithus merged 1 commit intomainfrom
feat/background

Conversation

@surfwithus
Copy link
Collaborator

@surfwithus surfwithus commented Jul 16, 2025

Summary by CodeRabbit

  • New Features
    • 밝은 회색 배경과 로고 워터마크가 포함된 새로운 배경 위젯(AppLightBackground)이 추가되었습니다.
    • 새로운 밝은 회색(AppColors.ongiLigntgrey)이 색상 팔레트에 추가되었습니다.

@coderabbitai
Copy link

coderabbitai bot commented Jul 16, 2025

Walkthrough

새로운 색상 상수가 AppColors 클래스에 추가되었으며, AppLightBackground라는 새로운 StatelessWidget이 도입되었습니다. 이 위젯은 지정된 자식 위젯 위에 연한 회색 배경과 투명한 로고 이미지를 겹쳐서 표시하는 역할을 합니다.

Changes

파일/경로 변경 요약
frontend/ongi/lib/core/app_colors.dart AppColors 클래스에 ongiLigntgrey 색상 상수 추가
frontend/ongi/lib/core/app_light_background.dart AppLightBackground StatelessWidget 신규 추가

Sequence Diagram(s)

sequenceDiagram
    participant Caller as 위젯 호출자
    participant AppLightBackground
    participant AppColors

    Caller->>AppLightBackground: child 위젯 전달
    AppLightBackground->>AppColors: ongiLigntgrey 색상 참조
    AppLightBackground->>AppLightBackground: 로고 이미지 배치 및 child 표시
    AppLightBackground-->>Caller: Stack 위젯 반환
Loading

Poem

🐇
연한 회색 배경 위에
로고가 살짝 비치네
새 위젯이 반겨주며
디자인이 더 밝아졌네
코드 속 작은 변화로
오늘도 토끼는 춤을 추네!


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@surfwithus surfwithus merged commit b5508ef into main Jul 16, 2025
3 of 4 checks passed
@surfwithus surfwithus deleted the feat/background branch July 16, 2025 14:16
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 58b3515 and 2b1ee98.

📒 Files selected for processing (2)
  • frontend/ongi/lib/core/app_colors.dart (1 hunks)
  • frontend/ongi/lib/core/app_light_background.dart (1 hunks)
🔇 Additional comments (2)
frontend/ongi/lib/core/app_light_background.dart (2)

12-15: 배경 위젯 깊이 최소화 제안

단순히 배경색만 설정할 경우 Container 대신 ColoredBox 혹은 const ColoredBox 를 사용하면 불필요한 위젯 트리를 줄일 수 있습니다.

-        Container(
-          color: AppColors.ongiLigntgrey,
-        ),
+        const ColoredBox(
+          color: AppColors.ongiLightGrey, // 상수명 변경 시 반영
+        ),

[ suggest_optional_refactor ]


20-25: 에셋 등록 확인 필요

assets/images/logo.pngpubspec.yamlflutter.assets 에 포함돼 있지 않으면 런타임에서 이미지 로드 실패가 발생합니다. 에셋 등록 여부를 다시 한 번 검증해 주세요.

class AppColors {
static const ongiOrange = Color(0xFFFD6C01);
static const ongiBlue = Color(0xFFBFECFF);
static const ongiLigntgrey = Color(0xFFF7F7F7);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

타이포 및 네이밍 컨벤션 불일치

ongiLigntgreyLight 의 오타이며, 기존 패턴(카멜-케이스)과도 맞지 않습니다. 추후 사용 시 혼동을 유발하니 즉시 수정하는 편이 좋습니다.

-  static const ongiLigntgrey = Color(0xFFF7F7F7);
+  static const ongiLightGrey = Color(0xFFF7F7F7);

수정 후, 해당 상수를 참조하는 모든 위치(특히 AppLightBackground)도 함께 업데이트하세요.


🏁 Script executed:

#!/bin/bash
# 오타 수정 전후 상수 및 관련 사용 위치 검색
rg "ongiLigntgrey" -n .
rg "ongiLightGrey" -n .
rg "AppLightBackground" -n .

Length of output: 484


Typo 및 네이밍 컨벤션 수정 필요

ongiLigntgreyLight의 철자 오류이며, 카멜케이스 패턴(ongiLightGrey)에도 맞지 않습니다. 아래 파일들을 함께 고쳐주세요.

• frontend/ongi/lib/core/app_colors.dart (6행)

-  static const ongiLigntgrey = Color(0xFFF7F7F7);
+  static const ongiLightGrey  = Color(0xFFF7F7F7);

• frontend/ongi/lib/core/app_light_background.dart (13행)

-          color: AppColors.ongiLigntgrey,
+          color: AppColors.ongiLightGrey,

위 두 군데를 수정한 뒤, 관련 레퍼런스가 없는지 한 번 더 확인 부탁드립니다.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
static const ongiLigntgrey = Color(0xFFF7F7F7);
// File: frontend/ongi/lib/core/app_colors.dart
static const ongiLightGrey = Color(0xFFF7F7F7);
Suggested change
static const ongiLigntgrey = Color(0xFFF7F7F7);
// File: frontend/ongi/lib/core/app_light_background.dart
color: AppColors.ongiLightGrey,
🤖 Prompt for AI Agents
In frontend/ongi/lib/core/app_colors.dart at line 6 and
frontend/ongi/lib/core/app_light_background.dart at line 13, fix the typo in the
color name from "ongiLigntgrey" to "ongiLightGrey" following camelCase
convention. After renaming, search the entire codebase for any references to the
old name and update them to the corrected name to ensure consistency and prevent
errors.

Neibce pushed a commit to 2025-PNU-SW-Hackathon/PNUSW-2025-OnGi-10 that referenced this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant