Bug sendmail sales purchases#1764
Merged
NeoRazorX merged 5 commits intoNeoRazorX:masterfrom Oct 1, 2025
Merged
Conversation
…piedades alternativas para 'nombrecliente' y 'numero2'.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the SendMail controller where sending purchase documents was failing due to missing properties on line 197. The fix adds dynamic property checking to handle different document types that may use different property names for customer/supplier names and document numbers.
- Replaces direct property access with conditional property checking using
property_exists() - Updates copyright year to 2025 in template files
- Adds version parameters to CSS/JS assets for cache busting
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Core/Controller/SendMail.php | Implements dynamic property checking to handle different document types with varying property names |
| Core/View/Master/MicroTemplate.html.twig | Updates copyright year and adds version parameters to asset URLs |
| Core/View/Master/MenuTemplate.html.twig | Updates copyright year and adds version parameters to asset URLs |
…to bug-sendmail-sales-purchases # Conflicts: # Core/View/Master/MenuTemplate.html.twig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Al enviar un documento de compras da error en la línea 197 porque no existen las propiedades adecuadas.
¿Cómo has probado los cambios?
Toda modificación debe haber sido mínimamente probada. Marca o describe las pruebas que has realizado: